[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Prototype Code Review Dashboards (input required)

> On 4 Mar 2016, at 09:21, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>> On 04.03.16 at 10:05, <lars.kurth.xen@xxxxxxxxx> wrote:
>>> On 4 Mar 2016, at 08:42, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>>> On 03.03.16 at 19:55, <lars.kurth.xen@xxxxxxxxx> wrote:
>>>>> On 2 Mar 2016, at 22:45, Daniel Izquierdo <dizquierdo@xxxxxxxxxxxx> wrote:
>>>>> On 01/03/16 18:04, Lars Kurth wrote:
>>>>>> It may be better to use the following definition (although, others may 
>>>>>> disagree)
>>>>>> A reviewer is someone who did one of the following for a patch or series:
>>>>>> - Added a reviewed-by flag
>>>>>> - Added an acked-by flag (maintainers tend to use acked-by)
>>>>>> - Made a comment, but is NOT the author
>> @Jan, the use-case to measure real review contributions was primarily added 
>> on your request. Do you think the proposed definition above, is good enough?
> Yes, the last bullet point should be what mostly addresses my
> original concern. Some differentiation between Acked-by and
> Reviewed-by may also help - remember that in the case of
> maintainers we generally mean the latter to imply the former,
> and that in the case of non-maintainers the former doesn't
> really mean much.

Sounds as if an approach similar to the one taken for the commit vs. review 
balance may make sense
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.