Re: [Xen-devel] [PATCH V2 0/9] xentrace/xenalyze support on ARM

[Julien Grall <julien.grall@xxxxxxx>]

Hello,

On 04/04/2016 15:11, Wei Liu wrote:
> On Fri, Apr 01, 2016 at 04:33:44PM -0400, Benjamin Sanda wrote:
> > ---
> > Changed since v1:
> >    * Removed Flask changes as deemed uncessesary and unclear in
> >      purpose
> >    * Corrected all commit messages to be line limited to 72 chars
> >    * Implimented v1 review comments as indicated in each file's
> >      commit log.
> >
> > Benjamin Sanda (9):
> >    xenalyze: Support for ARM platform
> >    xentrace: Support for ARM platform
> >    xentrace: Support for ARM platform
> >    xentrace: Support for ARM platform
> >    xentrace: Support for ARM platform
> >    xentrace: Support for ARM platform
> >    xentrace: Support for ARM platform
> >    xentrace: Support for ARM platform
> >    xentrace: Support for ARM platform
> You patches all have the same subject line.  Please make them more
> specific. See my reply to #1 for example.
+1

Also, you should at least check that Xen still builds after applying 
each patch. Ideally, you also need to be careful to not break any 
feature currently supported. It's useful when someone needs to bisect 
the tree.
For instance, you use the function get_pg_owner for ARM in patch #2 but 
introduce the function in patch #4. This will break ARM build. So the 
patch #2 should be moved after #4.
Furthermore, you remove the functions get_pg_owner and put_pg_owner for 
x86 in patch #3 and then re-introduced them in patch #4. Therefore, the 
x86 will be broken after #3. In this case, it's better to have a patch 
that move the 2 functions from x86 to common.
Finally, please CC all the x86 maintainers (Jan and Andrew) on x86 
changes. You need to manually check the CCs as under certain conditions 
the script get_maintainers.pl may not return all the relevant maintainers.
I will wait the next iteration of this series to review the code.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel