Re: [Xen-devel] [PATCH v5 10/28] xsplice: Implement payload loading

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Tue, Apr 05, 2016 at 12:45:44PM -0400, Konrad Rzeszutek Wilk wrote:
> > > -void *vm_alloc(unsigned int nr, unsigned int align)
> > > +void __init vm_init(void)
> > > +{
> > > +    vm_init_type(VMAP_VIRT);
> > > +#ifdef CONFIG_XSPLICE
> > > +    vm_init_type(XEN_VIRT);
> > > +#endif
> > > +}
> > 
> > I think we should leave it to the arch to call vm_init_type() for
> > the non-default type(s) it cares about, namely allowing for this to
> > be done at a different (later) time. Which means vm_init() could
> > simply become an inline/macro wrapper of vm_init_type(VMAP_VIRT).
> 
> Yup, and then I've an arch_xsplice_init which nicely calls vm_init_type
> for the VMAP_VIRT_XEN.
> 
> > 
> > > +void *vm_alloc(unsigned int nr, unsigned int align)
> > > +{
> > > +    return vm_alloc_type(nr, align, VMAP_VIRT);
> > > +}
> > 
> > Inline/macro wrapper?

I would prefer to have this inside the common/vmap.c file as I would
need to expose vm_alloc_type in the header file - which is really not
to be used by users of the vmalloc API.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel