[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 10/28] xsplice: Implement payload loading

>>>> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 04/05/16 7:49 PM >>>
>On Tue, Apr 05, 2016 at 12:45:44PM -0400, Konrad Rzeszutek Wilk wrote:
>> > > +void *vm_alloc(unsigned int nr, unsigned int align)
>> > > +{
>> > > +    return vm_alloc_type(nr, align, VMAP_VIRT);
>> > > +}
>> > 
>> > Inline/macro wrapper?
>I would prefer to have this inside the common/vmap.c file as I would
>need to expose vm_alloc_type in the header file - which is really not
>to be used by users of the vmalloc API.

If you don't expose it, how would xSplice be able to make use of it? But yes,
if indeed that would become the only reason preventing something to be static,
then it probably shouldn't become an inline wrapper.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.