Re: [Xen-devel] [PATCH v5 10/28] xsplice: Implement payload loading

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 04/05/16 6:46 PM >>>
>> > +    if ( mfn_array )
>> > +        *mfn_array = mfn;
>> > +    else
>> > +        xfree(mfn);
>> 
>> What's this? I certainly assumed this wouldn't be needed anymore
>> now.
>
>I still need the MFNs so I can change the page table attributes once
>I've finished copying the ELF.
>
>I can walk the virtual addresses and gather them from the PTE,
>but I figured it would be easier to have them stashed away somewhere?

Both alternatives aren't really neat, but I think exposing the MFN list via the
vmalloc interface is the uglier variant. I.e. I'd prefer doing it Linux'es way,
perhaps even having a specialized sibling to map_pages_to_xen() which
only alters attributes without changing the frame numbers.
 
Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel