Re: [Xen-devel] [libvirt] [PATCH] libxl: use LIBXL_API_VERSION 0x040200

[Martin Kletzander <mkletzan@xxxxxxxxxx>]

On Wed, Apr 13, 2016 at 05:37:05PM -0600, Jim Fehlig wrote:
> To ensure the libvirt libxl driver will build with future versions
> of Xen where the libxl API may change in incompatible ways,
> explicitly use LIBXL_API_VERSION 0x040200. The libxl driver
> does use new libxl APIs that have been added since Xen 4.2, but
> currently it does not make use of any changes made to existing
> APIs such as libxl_domain_create_restore or libxl_set_vcpuaffinity.
> The version can be bumped if/when the libxl driver consumes the
> changed APIs.
>
> Further details can be found in the following discussion thread
>
> https://www.redhat.com/archives/libvir-list/2016-April/msg00178.html
> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx>
> ---
> src/Makefile.am          |  1 +
> src/libxl/libxl_conf.h   | 12 ------------
> src/libxl/libxl_domain.c | 15 ---------------
> 3 files changed, 1 insertion(+), 27 deletions(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 08ff301..259a474 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -1311,6 +1311,7 @@ endif ! WITH_DRIVER_MODULES
>
> libvirt_driver_libxl_impl_la_CFLAGS =           \
>                 $(LIBXL_CFLAGS)                 \
> +               -DLIBXL_API_VERSION=0x040200    \
Adding it to LIBXL_CFLAGS in configure.ac would make it show after
configure, but that's something probably only I would find interesting
=)  I'm no libxl expert and I don't have it on my system, so I can't try
building it, hence only weak ACK from me.  If it build for you then it's
fine as nobody objects as I see.

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel