Re: [Xen-devel] [PATCH v8.1 13/27] x86/xen_hello_world.xsplice: Test payload for patching 'xen_extra_version'.

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx> 04/20/16 6:10 PM >>>
>> >+.PHONY: xsplice
>> >+xsplice: config.h
>> >+   # Need to have these done in sequential order
>> >+   $(MAKE) -f $(BASEDIR)/Rules.mk xen_hello_world_func.o
>> >+   $(MAKE) -f $(BASEDIR)/Rules.mk xen_hello_world.o
>> 
>> Why do these two need doing in order? And why can't $(XSPLICE) not just 
>> depend
>> on its to object files, without needing explict make invocation to generate 
>> them?
>
>That is b/c the the xen_hello_world.c depends on the generation of
>config.h.
>
>I _think_ I can do:
>xsplice: config.h xen_hello_world_func.o
>
>As the xen_hello_world_func.c should be able to be built without any
>dependencies.
>
>Or maybe I can do:
>
>xen_hello_world.o: config.h
>$(CC) $(CFLAGS) -c $< -o $@
>^^^ - copy-n-paste from Rules.mk

But why would you want to duplicate the rule? All you need is representation
of the dependency.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel