Re: [Xen-devel] [PATCH v4 1/9] livepatch: Clear .bss when payload is reverted

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.09.16 at 18:51, <konrad.wilk@xxxxxxxxxx> wrote:
> --- a/xen/common/livepatch_elf.c
> +++ b/xen/common/livepatch_elf.c
> @@ -86,7 +86,16 @@ static int elf_resolve_sections(struct livepatch_elf *elf, 
> const void *data)
>                      delta < sizeof(Elf_Ehdr) ? "at ELF header" : "is past 
> end");
>              return -EINVAL;
>          }
> -
> +        else if ( !(sec[i].sec->sh_flags & SHF_EXECINSTR) &&
> +                  (sec[i].sec->sh_flags & SHF_WRITE) &&
> +                  sec[i].sec->sh_type == SHT_NOBITS &&
> +                  sec[i].sec->sh_size > MB(2) )

What good do the two sh_flags checks do here?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel