[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 01/16] arm/x86/common: Add HAS_[ALTERNATIVE|EX_TABLE]



> > @@ -42,16 +42,16 @@ config ACPI
> >       Advanced Configuration and Power Interface (ACPI) support for Xen is
> >       an alternative to device tree on ARM64.
> > 
> > -config HAS_GICV3
> > +config HAS_ALTERNATIVE
> >     bool
> > 
> > -config ALTERNATIVE
> > +config HAS_GICV3
> >     bool
> 
> Why did you invert HAS_GICV3 and HAS_ALTERNATIVE? This makes the patch more
> difficult to read.

To be in alphabetic order. But considering I remove it immediately in
the next patch (as I move it to common/Kconfig) it is kind of pointless. 
> 
> Cheers,
> 
> -- 
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.