Re: [Xen-devel] [PATCH v5 06/16] livepatch: ARM/x86: Check displacement of old_addr and new_addr

[Julien Grall <julien.grall@xxxxxxx>]

Hi Konrad,

On 21/09/16 18:32, Konrad Rzeszutek Wilk wrote:
> diff --git a/xen/include/asm-arm/livepatch.h b/xen/include/asm-arm/livepatch.h
> index 929c7d9..482d74f 100644
> --- a/xen/include/asm-arm/livepatch.h
> +++ b/xen/include/asm-arm/livepatch.h
> @@ -6,6 +6,8 @@
>  #ifndef __XEN_ARM_LIVEPATCH_H__
>  #define __XEN_ARM_LIVEPATCH_H__
>
> +#include <xen/sizes.h> /* For SZ_* macros. */
> +
>  /* On ARM32,64 instructions are always 4 bytes long. */
>  #define ARCH_PATCH_INSN_SIZE 4
>
> @@ -15,6 +17,15 @@
>   */
>  extern void *vmap_of_xen_text;
>
> +/* These ranges are only for unconditional branches. */
> +#ifdef CONFIG_ARM_32
> +/* ARM32: A4.3 IN ARM DDI 0406C.j -  we are using only ARM instructions in 
> Xen.*/
NIT: There is no j revision of the ARMv7 manual. The latest on is 0406C.c.

With that:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel