Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Sep 26, 2016 at 11:20:50AM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v6] acpi: Prevent GPL-only code from seeping into 
> non-GPL binaries"):
> > On Fri, Sep 23, 2016 at 03:14:20PM -0400, Boris Ostrovsky wrote:
> > > +links="ABCD"
> > > +
> > > +for i in $(seq 0 3)
> > > +do
> > > +    link=${links:$i:1}
> > 
> > This is not portable.
> > 
> > Use following instead:
> > 
> > links="A B C D"
> > 
> > set $links
> > for link in $@
> 
> What's wrong with
> 
>   links="A B C D"
> 
>   for link in $links; do
>     ....
> 
> ?

Yes, I think this works, too.

I mistakenly thought that was bash-ism.

> 
> (To my surprise I discover that there are only marginal dependencies
> on bash already in xen.git, so we should probably avoid adding a new
> dependency on bash.)
> 

Agreed.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel