Re: [Xen-devel] [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 09/26/2016 09:08 AM, Jan Beulich wrote:
>>>> On 26.09.16 at 14:49, <boris.ostrovsky@xxxxxxxxxx> wrote:
>> On 09/26/2016 02:46 AM, Jan Beulich wrote:
>>>>>> On 23.09.16 at 21:14, <boris.ostrovsky@xxxxxxxxxx> wrote:
>>>> Changes in v6:
>>>> * Replaced script's printf in most case with "here document" (for 
>>>> multi-line
>>>>   text) or echo for single line. Left printf for formatted output.
>>>>   (Note that in one case paramter expansion is necessary and so
>>>>    delimiter word is intentionally not quoted).
>>>> * Replaced bash arrays with ${string:index:size} syntax.
>>> Without having looked at the patch in full yet - is this any more
>>> portable than the previous approach? I can't see any mention of
>>> it in SUSv6 / SUSv7 either.
>> I can't say for sure but I remember seeing this construct long time ago.
>>
>> Of course, this being bash, there are at least 3 ways of doing the same
>> thing so I can also do
>>
>>     link=`echo "A B C D" | cut  -d" " -f $i`
>>
>> Will SUSv6 understand this?
> Yes, it looks like it will. But you could have checked yourself.


Yes, I could. But somehow I thought you were referring to a SUSE product
instead of the UNIX spec.

Anyway, I will hold off re-sending the patch with this fixed until you
review the one I sent.

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel