Re: [Xen-devel] [XTF PATCH] Makefile: introduce gtags target

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/09/16 17:39, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  .gitignore |  3 +++
>  Makefile   | 10 +++++++++-
>  2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/.gitignore b/.gitignore
> index f69e7fc..28c7874 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -11,3 +11,6 @@
>  /selftests/test-*
>  /tests/*/test-*
>  /tests/*/info.json
> +/GPATH
> +/GRTAGS
> +/GTAGS
> diff --git a/Makefile b/Makefile
> index 17d784e..6767f72 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -50,11 +50,19 @@ install:
>               $(MAKE) -C $$D install; \
>       done
>  
> +define all_sources
> +    ( find include/ arch/ common/ tests/ -name "*.[hcsS]" )

Why the subshell?  It doesn't look necessary.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> +endef
> +
>  .PHONY: cscope
>  cscope:
> -     find include/ arch/ common/ tests/ -name "*.[hcsS]" > cscope.files
> +     $(all_sources) > cscope.files
>       cscope -b -q -k
>  
> +.PHONY: gtags
> +gtags:
> +     $(all_sources) | gtags -f -
> +
>  .PHONY: clean
>  clean:
>       find . \( -name "*.o" -o -name "*.d" -o -name "*.lds" \) -delete


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel