[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1 05/12] tmem: Delete deduplication (and tze) code.



>>> On 28.09.16 at 11:42, <konrad.wilk@xxxxxxxxxx> wrote:
> Couple of reasons:
>  - It can lead to security issues (see row-hammer, KSM and such
>    attacks).
>  - Code is quite complex.
>  - Deduplication is good if the pages themselves are the same
>    but that is hardly guaranteed.
>  - We got some gains (if pages are deduped) but at the cost of
>    making code less maintainable.
>  - tze depends on deduplication code.
> 
> As such, deleting it.

So why the prior two patches then? That way you've got more to
delete here than without.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.