Re: [Xen-devel] [PATCH v1 02/12] tmem: Retire XEN_SYSCTL_TMEM_OP_[SET_CAP|SAVE_GET_CLIENT_CAP]

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Sep 28, 2016 at 12:00:14PM +0100, Wei Liu wrote:
> On Wed, Sep 28, 2016 at 05:42:16AM -0400, Konrad Rzeszutek Wilk wrote:
> > It is not used by anything.
> > 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> > diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
> > index 8197c14..847ec35 100644
> > --- a/xen/include/public/sysctl.h
> > +++ b/xen/include/public/sysctl.h
> > @@ -757,14 +757,12 @@ DEFINE_XEN_GUEST_HANDLE(xen_sysctl_psr_cat_op_t);
> >  #define XEN_SYSCTL_TMEM_OP_DESTROY                3
> >  #define XEN_SYSCTL_TMEM_OP_LIST                   4
> >  #define XEN_SYSCTL_TMEM_OP_SET_WEIGHT             5
> > -#define XEN_SYSCTL_TMEM_OP_SET_CAP                6
> 
> I somehow have the impression that we should add a comment here saying
> that this number is now reserved -- but the reality disagrees with me.
> :-)

I was thinking that initially too, but then these subcommands are in
domctl and they are not in the tmem public API so we are free to muck
around.

So I figured I would reuse them as well and such.
> 
> >  #define XEN_SYSCTL_TMEM_OP_SET_COMPRESS           7
> >  #define XEN_SYSCTL_TMEM_OP_QUERY_FREEABLE_MB      8
> >  #define XEN_SYSCTL_TMEM_OP_SAVE_BEGIN             10
> >  #define XEN_SYSCTL_TMEM_OP_SAVE_GET_VERSION       11
> >  #define XEN_SYSCTL_TMEM_OP_SAVE_GET_MAXPOOLS      12
> >  #define XEN_SYSCTL_TMEM_OP_SAVE_GET_CLIENT_WEIGHT 13
> > -#define XEN_SYSCTL_TMEM_OP_SAVE_GET_CLIENT_CAP    14
> >  #define XEN_SYSCTL_TMEM_OP_SAVE_GET_CLIENT_FLAGS  15
> >  #define XEN_SYSCTL_TMEM_OP_SAVE_GET_POOL_FLAGS    16
> >  #define XEN_SYSCTL_TMEM_OP_SAVE_GET_POOL_NPAGES   17
> > -- 
> > 2.4.11
> > 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel