Re: [Xen-devel] [PATCH v2 06/30] x86/paging: introduce paging_set_allocation

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Thu, Sep 29, 2016 at 04:51:42AM -0600, Jan Beulich wrote:
> >>> On 27.09.16 at 17:57, <roger.pau@xxxxxxxxxx> wrote:
> > @@ -1383,15 +1382,25 @@ int __init construct_dom0(
> >                           nr_pages);
> >      }
> >  
> > -    if ( is_pvh_domain(d) )
> > -        hap_set_alloc_for_pvh_dom0(d, dom0_paging_pages(d, nr_pages));
> > -
> >      /*
> >       * We enable paging mode again so guest_physmap_add_page will do the
> >       * right thing for us.
> >       */
> 
> I'm afraid you render this comment stale - please adjust it accordingly.

Not AFAICT, this comment is referring to the next line, which is:

d->arch.paging.mode = save_pvh_pg_mode;

The classic PVH domain builder contains quite a lot of craziness and 
disables paging modes at certain points by playing with d->arch.paging.mode.

> > --- a/xen/arch/x86/mm/paging.c
> > +++ b/xen/arch/x86/mm/paging.c
> > @@ -954,6 +954,22 @@ void paging_write_p2m_entry(struct p2m_domain *p2m, 
> > unsigned long gfn,
> >          safe_write_pte(p, new);
> >  }
> >  
> > +int paging_set_allocation(struct domain *d, unsigned long pages, int 
> > *preempted)
> 
> Since you need to touch the other two functions anyway, please
> make the last parameter bool * here and there.

OK, that's fine.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel