Re: [Xen-devel] [PATCH v9 04/13] x86: properly calculate xen ELF end of image address

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.09.16 at 23:42, <daniel.kiper@xxxxxxxxxx> wrote:
> This patch is prereq for "efi: build xen.gz with EFI code" patch which adds,
> among others, xen/arch/x86/efi/relocs-dummy.S to xen.gz output. Below there
> is a description why it is needed.
> 
> Currently xen ELF end of image address is calculated using first line from
> "nm -nr xen/xen-syms" output. However, potentially it may contain symbol
> address not related to the end of image in any way. It can happen if a 
> symbol
> is introduced with address larger than _end symbol address. Such situation
> encountered when I linked xen ELF binary with 
> xen/arch/x86/efi/relocs-dummy.S.
> Then first line from "nm -nr xen/xen-syms" contained "ffff82d0c0000000 A 
> ALT_START"
> and xen ELF image memory size was silently set to 1023 MiB. This issue 
> happened
> because there is no check which symbol address is used to calculate end of
> image address. So, let's fix it and take ELF end of image address by reading
> __2M_rwdata_end symbol address from nm output. This way xen ELF image build
> process is not prone to changes in order of nm output.
> 
> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel