Re: [Xen-devel] [PATCH v2 08/10] libxl: fix coding style of credit1 parameters related functions

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Fri, 2016-09-30 at 11:24 +0100, Ian Jackson wrote:
> Dario Faggioli writes ("[PATCH v2 08/10] libxl: fix coding style of
> credit1 parameters related functions"):
> >  int libxl_sched_credit_params_set(libxl_ctx *ctx, uint32_t poolid,
> >                                    libxl_sched_credit_params
> > *scinfo)
> >  {
> >      struct xen_sysctl_credit_schedule sparam;
> > -    int rc=0;
> > +    int r, rc;
> ...
> > 
> >  
> >      scinfo->tslice_ms = sparam.tslice_ms;
> >      scinfo->ratelimit_us = sparam.ratelimit_us;
> >  
> > + out:
> >      GC_FREE;
> > -    return 0;
> > +    return rc;
> 
> I think this is missing an assignment
> 
>   rc = 0;
> 
> on the successful exit path, just before out.  Am I wrong ?
> 
Indeed it's missing. It was not necessary in v1 of this patch, so I
must have failed to notice that it was, when splitting that in two.

Sorry.

Not sure how to proceed, so I'm attaching an updated version of the
patch to this email.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: libxl-fix-coding-style-sched-param.patch
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel