Re: [Xen-devel] [PATCH 1/5] x86emul: support UMIP

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.09.16 at 14:27, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 30/09/16 13:23, Jan Beulich wrote:
>>>>> On 30.09.16 at 12:32, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> On 08/09/16 14:42, Jan Beulich wrote:
>>>> @@ -1484,6 +1485,17 @@ static bool is_aligned(enum x86_segment
>>>>      return !((reg.base + offs) & (size - 1));
>>>>  }
>>>>  
>>>> +static bool is_umip(struct x86_emulate_ctxt *ctxt,
>>>> +                    const struct x86_emulate_ops *ops)
>>> is_umip is an odd way of phrasing this.  umip_enabled() or
>>> is_umip_enabled() would be better.
>> That would have been my choice if there wasn't the CPL check in here.
>> I prefer to read the 'p' here as "prevented" rather then "prevention".
> 
> In which case, umip_active()?

Ah - that's fine.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel