Re: [Xen-devel] [PATCH for-4.8] ipxe: update to newer commit

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.10.16 at 16:27, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 10/11/2016 09:32 AM, Ian Jackson wrote:
>> Boris Ostrovsky writes ("Re: [Xen-devel] [PATCH for-4.8] ipxe: update to 
> newer commit"):
>>> On 10/11/2016 05:52 AM, Ian Jackson wrote:
>>>> Maybe we could consider these as backports to earlier releases.
>>>> However, I looked at the patch and it mostly seems to be removing null
>>>> pointer checks.  I find this ... surprising.
>>> That's because routines have __nonnull attribute (which tells compiler
>>> that arguments are never NULL) and new gcc warns on non-NULL checks for
>>> these arguments.
>> *sigh*  Why don't we just disable that warning ?
> 
> We could but what if an old compiler doesn't support that option?
> Although it looks like -Wno-<option>, which is what we'd use, may be OK:
> 
> ostr@workbase> gcc foo.c
> ostr@workbase> gcc -Wfoo foo.c
> gcc: error: unrecognized command line option ‘-Wfoo’; did you mean ‘-Wno-’?
> ostr@workbase> gcc -Wno-foo foo.c
> ostr@workbase>

Just fyi I have run into an issue with -Wno-override-init use in Linux
4.8 on gcc 4.1.x, so what you say doesn't appear to hold for all gcc
versions we permit to be used.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel