[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.8] ipxe: update to newer commit



>>> On 11.10.16 at 23:11, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 11/10/2016 14:32, Ian Jackson wrote:
>> Boris Ostrovsky writes ("Re: [Xen-devel] [PATCH for-4.8] ipxe: update to 
>> newer commit"):
>>> BTW, another option for backporting may be removing -Werror. If we know
>>> we are not changing sources then we might consider this.
>> Perhaps we could disable warnings more selectively.
> 
> This code hasn't changed in ages.  Irrespective of what newer compilers
> think, it won't start working differently,

I'm afraid this is not a good position to take: Newer gcc may also be
more aggressive in terms of eliminating code with undefined behavior,
and warnings for such cases are a useful (pre)indicator.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.