Re: [Xen-devel] [PATCH v1 02/10] iommu: Add extra order argument to the IOMMU APIs and platform callbacks

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.05.17 at 16:03, <olekstysh@xxxxxxxxx> wrote:
> @@ -771,6 +773,47 @@ int amd_iommu_unmap_page(struct domain *d, unsigned long 
> gfn)
>      return 0;
>  }
>  
> +/* TODO: Optimize by squashing map_pages/unmap_pages with 
> map_page/unmap_page */

Looking over the titles of the rest of this series it doesn't look like
you're eliminating this TODO later. While I appreciate this not
being done in the already large patch, I don't think such a TODO
should be left around. If need be (e.g. because you can't test
the change), get in touch with the maintainer(s).

> +int __must_check amd_iommu_unmap_pages(struct domain *d, unsigned long gfn,
> +                                       unsigned int order)
> +{
> +    unsigned long i;
> +    int rc = 0;
> +
> +    for ( i = 0; i < (1UL << order); i++ )
> +    {
> +        int ret = amd_iommu_unmap_page(d, gfn + i);
> +        if ( !rc )

Blank line between declaration(s) and statement(s) please.

x86 and generic iommu parts (and _only_ those, so please don't
convert this into a blanket R-b)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel