Re: [Xen-devel] [PATCH for-4.9] build: stubdom and tools should depend on public header target

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.05.17 at 17:05, <wei.liu2@xxxxxxxxxx> wrote:
> On Wed, May 17, 2017 at 03:51:11PM +0100, Wei Liu wrote:
>> On Wed, May 17, 2017 at 08:28:40AM -0600, Jan Beulich wrote:
>> > >>> On 17.05.17 at 16:20, <ian.jackson@xxxxxxxxxxxxx> wrote:
>> > > Wei Liu writes ("Re: [PATCH for-4.9] build: stubdom and tools should 
>> > > depend 
> 
>> > > on public header target"):
>> > >> On Wed, May 17, 2017 at 02:16:39PM +0100, Ian Jackson wrote:
>> > >> > The new code in the Makefiles LGTM.  I have only one nit, which is
>> > >> > that style for Makefile targets seems to be to use `-' rather than `_'
>> > >> > as a word separator.
>> > >> 
>> > >> IIRC at one point I used '-' in mini-os build system but some version of
>> > >> make didn't like it. So I stick with '_' since.
>> > > 
>> > > I think you are confused.  You are probably thinking of variable names
>> > > which cannot contain -.  (Well, which are troublesome if they do.)
>> > 
>> > Troublesome? I'm pretty sure we use such somewhere in the
>> > hypervisor tree...
>> 
>> Then we'd better fix it sooner rather than later. :p
>> 
>> I dig out the patch. And this is in the commit message:
>> 
>>     In the GNU make manual "How to Use Variables" section there is such
>>     word:
>> 
>>     "However, variable names containing characters other than letters,
>>     numbers, and underscores should be considered carefully, as in some
>>     shells they cannot be passed through the environment to a sub-make (see
>>     Communicating Variables to a Sub-make)."
>> 
> 
> $ cd xen.git/xen
> $ git-ls-files | grep '\(Rules.*\|Makefile.*\|[Cc]onfig.*\)' | xargs \
>    grep -nH '[A-Z_]+-.*' # yields nothing

It must have overlooked thinks like

subdir-y += acpi
subdir-y += cpu
subdir-y += genapic

Ah, indeed, you did look for uppercase names only.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel