[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 5/8] osstest: introduce a FreeBSD build script
On Fri, Jun 23, 2017 at 03:56:20PM +0100, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH v3 5/8] osstest: introduce a FreeBSD build > script"): > > The following new helpers are also introduced, that are only used by > > the FreeBSD build script: buildcmd_stamped_logged_root and > > target_cmd_build_root, they behave exactly the same as the non-root > > counterparts. > > Please split these out into a separate patch. Done. > > diff --git a/ts-freebsd-build b/ts-freebsd-build > > new file mode 100755 > > index 00000000..6c10eece > > --- /dev/null > > +++ b/ts-freebsd-build > ... > > +sub install_deps () { > > + target_cmd_root($ho, 'pkg-static install git', 300); > > +} > > This needs to be concurrency-safe, I think, since it might run > simultaneously in differnet jobs. Is it ? Yes, it needs to be concurrency safe and it's not. I've added a pre-patch that adds FreeBSD support to target_install_packages, although there's no translation layer yet. I've used lockf [0] instead of with-lock-ex, which is the default lock file utility in FreeBSD. > I wonder if the right answer is for you to call > target_install_packages > and teach target_install_packages a mapping from the Debian package > names to FreeBSD ones, and how to do package installation on FreeBSD. > > > + logm("Cleaning up previous builds"); > > + buildcmd_stamped_logged(300, 'freebsd', 'cleanworld', > > + $prefix, 'make cleanworld', ''); > > + > > + logm("Building world"); > > + buildcmd_stamped_logged(25200, 'freebsd', 'buildworld', > > + $prefix, <<END, ''); > > +make $makeflags buildworld > > +END > > + > > + logm("Building kernel"); > > + buildcmd_stamped_logged(3600, 'freebsd', 'buildkernel', > > + $prefix, <<END, ''); > > +make $makeflags buildkernel > > +END > > These are quite formulaic, aren't they ? Maybe you want to make a > sub for them (either global in this file, or an anon subref). Yes, since the code is already quite small I didn't made a stub, but I certainly don't mind adding one. Thanks, Roger. [0] https://www.freebsd.org/cgi/man.cgi?query=lockf _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |