Re: [Xen-devel] [PATCH RFC] xen/evtchn: Implement EVTCHNOP_send_imm as a companian to EVTCHNOP_send

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.07.17 at 09:50, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -1098,6 +1098,10 @@ long do_event_channel_op(int cmd, 
> XEN_GUEST_HANDLE_PARAM(void) arg)
>          break;
>      }
>  
> +    case EVTCHNOP_send_imm:
> +        rc = evtchn_send(current->domain, (unsigned long)arg.p);

Two more things: For one this discards the upper half of the 64-bit
handle. I'd suggest you instead check it to be zero. And then x86's
do_event_channel_op_compat() should refuse to handle "immediate"
commands.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel