Re: [Xen-devel] [OSSTEST PATCH v12 18/21] TestSupport: Implement target_cmd_subunit a subunit stream parser into substeps

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Anthony PERARD writes ("Re: [OSSTEST PATCH v12 18/21] TestSupport: Implement 
target_cmd_subunit a subunit stream parser into substeps"):
> On Thu, Jul 13, 2017 at 03:43:55PM +0100, Anthony PERARD wrote:
> > Will do. And yes, this will duplicate most of the output. But it can
> > help debug osstest, for everything that the parser ignore.
> 
> I can't figure out what should target_cmd_stashed prototype be. Should
> it be like target_cmd_output (returning the output of the cmd) ? Or
> maybe like target_cmd but return a filename (which contain the output of
> the cmd) ?

Either of these will do I think.  Either return the filename and have
the caller use get_filecontents, or simply return the contents.

> I thought also about returning an file descriptor but it may
> not be a good idee to leave the caller with an open fd.

That's probably annoying.

> Also, how to call the stashed file ? So far, I would go with "$job". Or
> maybe adding an argument to target_cmd_stashed so the caller can choose
> a filename.

target_cmd_stashed should use open_unique_stashfile and should
therefore pass $leafref from its caller.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel