Re: [Xen-devel] [PATCH 13/25 v6] xen/arm: vpl011: Add a new add_console_evtchn_fd function in xenconsole

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jul 17, 2017 at 06:36:43PM +0530, Bhupinder Thakur wrote:
> This patch introduces a new add_console_evtchn_fd function. This
> function adds the console event channel FD to list of polled FDs.
> 
> Signed-off-by: Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>
> ---
> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxx>
> 
> Changes since v5:
> - Split this change in a separate patch.
> 
>  tools/console/daemon/io.c | 34 ++++++++++++++++++++++------------
>  1 file changed, 22 insertions(+), 12 deletions(-)
> 
> diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c
> index e4882e2..dc96203 100644
> --- a/tools/console/daemon/io.c
> +++ b/tools/console/daemon/io.c
> @@ -1048,6 +1048,27 @@ static void reset_fds(void)
>               memset(fds, 0, sizeof(struct pollfd) * current_array_size);
>  }
>  
> +static void add_console_evtchn_fd(struct console *con, void *data)

There is no need to use void *. Just use long long * here.

Or, you can avoid using pointer by returning the new timeout

  next_timeout = maybe_add_console_evtchn_fd(con, next_timeout);

Up to you.

> +{
> +     long long next_timeout = *((long long *)data);
> +
> +     if (con->event_count >= RATE_LIMIT_ALLOWANCE) {
> +             /* Determine if we're going to be the next time slice to expire 
> */
> +             if (!next_timeout ||
> +                 con->next_period < next_timeout)
> +                     next_timeout = con->next_period;
> +     } else if (con->xce_handle != NULL) {
> +                     if (buffer_available(con))
> +                     {
> +                             int evtchn_fd = xenevtchn_fd(con->xce_handle);
> +                             con->xce_pollfd_idx = set_fds(evtchn_fd,
> +                                                           POLLIN|POLLPRI);
> +                     }
> +             }

Indentation is wrong.

And please add maybe_ prefix because it doesn't always add the fd.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel