Re: [Xen-devel] [RFC PATCH v3 23/24] NUMA: Move CONFIG_NUMA to common Kconfig

[Julien Grall <julien.grall@xxxxxxx>]

On 18/07/17 17:25, Julien Grall wrote:
> Hi,
>
> On 18/07/17 12:41, vijay.kilari@xxxxxxxxx wrote:
> > From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
> >
> > CONFIG_NUMA is defined in xen/drivers/acpi/Kconfig.
> > Move to common/Kconfig and enabled by default.
> > Also, NUMA feature uses PDX for physical address to
> > memory node mapping. Hence make HAS_PDX dependent
> > for NUMA.
> >
> > Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
> > ---
> >  xen/common/Kconfig       | 4 ++++
> >  xen/drivers/acpi/Kconfig | 3 ---
> >  2 files changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> > index dc8e876..6e421c7 100644
> > --- a/xen/common/Kconfig
> > +++ b/xen/common/Kconfig
> > @@ -41,6 +41,10 @@ config HAS_GDBSX
> >  config HAS_IOPORTS
> >      bool
> >
> > +config NUMA
> > +    def_bool y
> > +    depends on HAS_PDX
> On previous version, Jan asked to remove the dependency on PDX. You said
> you will do it... So why it is not done?
>
> > +
> >  config HAS_BUILD_ID
> >      string
> >      option env="XEN_HAS_BUILD_ID"
> > diff --git a/xen/drivers/acpi/Kconfig b/xen/drivers/acpi/Kconfig
> > index b64d373..488372f 100644
> > --- a/xen/drivers/acpi/Kconfig
> > +++ b/xen/drivers/acpi/Kconfig
> > @@ -4,6 +4,3 @@ config ACPI
> >
> >  config ACPI_LEGACY_TABLES_LOOKUP
> >      bool
> > -
> > -config NUMA
> > -    bool
Also, you haven't addressed Jan comments here too:

"This makes clear that so far this is an option which architectures
are expected to select. I think we want it to remain that way, but
if we didn't you should remove the existing select(s)."

I would lean towards keeping selectable from the architecture KConfig. 
This would allow a new architecture to not enable NUMA if not supported.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel