Re: [Xen-devel] [PATCH v6 18/20] osstest: hook FreeBSD flight into cr-daily-branch

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Mon, Jul 24, 2017 at 04:44:09PM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v6 18/20] osstest: hook FreeBSD flight into 
> cr-daily-branch"):
> > Add the missing pieces so that cr-daily-branch knows how to create a
> > FreeBSD flight. This has been tested by calling `./cr-daily-branch
> > freebsd-master`.
> ...
> > +TREE_FREEBSD=$PUSH_TREE_FREEBSD
> 
> PUSH_TREE_FREEBSD seems not to be defined.  Have I missed something ?
> Likewise BASE_TREE_FREEBSD.

That's added in patch 17/20: "osstest: introduce a script to create a
FreeBSD flight". I guess I should move it here for coherency.

> > +   cd $repos/freebsd
> > +   git push $TREE_FREEBSD $revision:refs/heads/$branchcore
> 
> We don't normally call the osstest output branch for trees which are
> managed by someone else, "master".  Maybe we want another name ?

osstest-master, likewise we are going to have osstest-stable/11 if
that looks fine.

> Especially if this is going into xenbits's toplevel - but maybe it
> isn't.
> 
> Apart from that this looks OK, but of course it probably needs a call
> to mg-anoint.

Thanks. Would you like me to merge the next patch (the mg-anoint
integration) with this one?

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel