Re: [Xen-devel] [PATCH v14 09/23] x86: refactor psr: L3 CAT: set value: assemble features value array.

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx> 07/15/17 2:47 AM >>>
>@@ -619,6 +710,46 @@ static int insert_val_into_array(uint32_t val[],
>enum cbm_type type,
>uint32_t new_val)
>{
>+    const struct feat_node *feat;
>+    const struct feat_props *props;
>+    unsigned int i;
>+    int ret;
>+
>+    ASSERT(feat_type < FEAT_TYPE_NUM);
>+
>+    ret = skip_prior_features(&array_len, feat_type);
>+    if ( ret < 0 )
>+        return ret;
>+    else
>+        val += ret;

Please avoid such pointless "else".

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel