Re: [Xen-devel] 答复: [PATCH v3] x86/cpu: Add supports for zhaoxin x86 platform

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.05.18 at 04:54, <DavidWang@xxxxxxxxxxx> wrote:
> 发件人: Jan Beulich <JBeulich@xxxxxxxx>
> 发送时间: 2018年5月3日 23:09
>> +    if ( cpu_has(c, X86_FEATURE_ITSC) )
>> +    {
>> +        __set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability);
>> +        __set_bit(X86_FEATURE_NONSTOP_TSC, c->x86_capability);
>> +        __set_bit(X86_FEATURE_TSC_RELIABLE, c->x86_capability);
>> +    }
>> +
>> +    l2 = init_intel_cacheinfo(c);
>> +}
> 
> ... this is its only use?
> Yes, it Only be used to save the return value. I think it is unnecessary but 
> calls of  init_intel_cacheinfo() (in init_intel()) make me confused. Can i 
> delete it in patch v4?

If you don't need the value, you should (not just "can") remove the variable.

Also, I think I had mentioned this before: Please adjust your quoting style
when replying to mails.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel