[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH 0/7] x86: Structure naming and consistency improvements



This series started by trying to address the bug in patch 7, and ballooned
somewhat.

It is semi RFC because I expect there might be some objection in principle to
a series this invasive, but I can't find any less invasive way of making the
changes.  In particular, we can't use #define's to stage the changes over
time, because it interferes with local variables with the same name.

Overall, I think the series is enough of an improvement for it to be
considered.

Andrew Cooper (7):
  x86/pv: Rename d->arch.pv_domain to d->arch.pv
  x86/pv: Rename v->arch.pv_vcpu to v->arch.pv
  xen/hvm: Rename d->arch.hvm_domain to d->arch.hvm
  x86/hvm: Rename v->arch.hvm_vcpu to v->arch.hvm
  x86/vtx: Rename arch_vmx_struct to vmx_vcpu
  x86/svm: Rename arch_svm_struct to svm_vcpu
  x86/hvm: Drop hvm_{vmx,svm} shorthands

 xen/arch/arm/domain_build.c             |   2 +-
 xen/arch/arm/hvm.c                      |   4 +-
 xen/arch/x86/cpu/amd.c                  |   6 +-
 xen/arch/x86/cpu/intel.c                |   6 +-
 xen/arch/x86/cpu/vpmu.c                 |   2 +-
 xen/arch/x86/cpuid.c                    |  12 +-
 xen/arch/x86/domain.c                   |  96 +++----
 xen/arch/x86/domain_page.c              |  14 +-
 xen/arch/x86/domctl.c                   | 104 ++++----
 xen/arch/x86/hvm/asid.c                 |   2 +-
 xen/arch/x86/hvm/dm.c                   |  12 +-
 xen/arch/x86/hvm/dom0_build.c           |   4 +-
 xen/arch/x86/hvm/domain.c               |  40 +--
 xen/arch/x86/hvm/emulate.c              |  28 +-
 xen/arch/x86/hvm/hpet.c                 |  10 +-
 xen/arch/x86/hvm/hvm.c                  | 307 +++++++++++-----------
 xen/arch/x86/hvm/hypercall.c            |   6 +-
 xen/arch/x86/hvm/intercept.c            |  14 +-
 xen/arch/x86/hvm/io.c                   |  60 ++---
 xen/arch/x86/hvm/ioreq.c                |  84 +++---
 xen/arch/x86/hvm/irq.c                  |  56 ++--
 xen/arch/x86/hvm/mtrr.c                 |  36 +--
 xen/arch/x86/hvm/pmtimer.c              |  42 +--
 xen/arch/x86/hvm/rtc.c                  |   4 +-
 xen/arch/x86/hvm/save.c                 |   6 +-
 xen/arch/x86/hvm/stdvga.c               |  18 +-
 xen/arch/x86/hvm/svm/asid.c             |   4 +-
 xen/arch/x86/hvm/svm/emulate.c          |   4 +-
 xen/arch/x86/hvm/svm/intr.c             |   8 +-
 xen/arch/x86/hvm/svm/nestedsvm.c        |  72 +++--
 xen/arch/x86/hvm/svm/svm.c              | 248 +++++++++---------
 xen/arch/x86/hvm/svm/vmcb.c             |  16 +-
 xen/arch/x86/hvm/vioapic.c              |  44 ++--
 xen/arch/x86/hvm/viridian.c             | 120 ++++-----
 xen/arch/x86/hvm/vlapic.c               |   8 +-
 xen/arch/x86/hvm/vmsi.c                 |  44 ++--
 xen/arch/x86/hvm/vmx/intr.c             |  20 +-
 xen/arch/x86/hvm/vmx/realmode.c         |  28 +-
 xen/arch/x86/hvm/vmx/vmcs.c             | 174 ++++++-------
 xen/arch/x86/hvm/vmx/vmx.c              | 448 ++++++++++++++++----------------
 xen/arch/x86/hvm/vmx/vvmx.c             |  96 +++----
 xen/arch/x86/hvm/vpic.c                 |  20 +-
 xen/arch/x86/hvm/vpt.c                  |  94 +++----
 xen/arch/x86/i387.c                     |   2 +-
 xen/arch/x86/irq.c                      |  10 +-
 xen/arch/x86/mm.c                       |  24 +-
 xen/arch/x86/mm/hap/guest_walk.c        |   2 +-
 xen/arch/x86/mm/hap/hap.c               |  15 +-
 xen/arch/x86/mm/mem_sharing.c           |   6 +-
 xen/arch/x86/mm/p2m-ept.c               |   6 +-
 xen/arch/x86/mm/shadow/common.c         |  18 +-
 xen/arch/x86/mm/shadow/multi.c          |  20 +-
 xen/arch/x86/physdev.c                  |  11 +-
 xen/arch/x86/pv/callback.c              |  42 +--
 xen/arch/x86/pv/descriptor-tables.c     |  18 +-
 xen/arch/x86/pv/dom0_build.c            |   8 +-
 xen/arch/x86/pv/domain.c                |  65 +++--
 xen/arch/x86/pv/emul-gate-op.c          |   4 +-
 xen/arch/x86/pv/emul-priv-op.c          |  42 +--
 xen/arch/x86/pv/iret.c                  |  10 +-
 xen/arch/x86/pv/misc-hypercalls.c       |   4 +-
 xen/arch/x86/pv/mm.c                    |  10 +-
 xen/arch/x86/pv/traps.c                 |  10 +-
 xen/arch/x86/setup.c                    |  10 +-
 xen/arch/x86/time.c                     |  16 +-
 xen/arch/x86/traps.c                    |  24 +-
 xen/arch/x86/x86_64/asm-offsets.c       |  48 ++--
 xen/arch/x86/x86_64/entry.S             |   2 +-
 xen/arch/x86/x86_64/mm.c                |  10 +-
 xen/arch/x86/x86_64/traps.c             |  18 +-
 xen/arch/x86/x86_emulate.c              |   2 +-
 xen/common/vm_event.c                   |   2 +-
 xen/drivers/passthrough/io.c            |   2 +-
 xen/drivers/passthrough/pci.c           |   2 +-
 xen/drivers/vpci/msix.c                 |   6 +-
 xen/include/asm-arm/domain.h            |   2 +-
 xen/include/asm-x86/domain.h            |  16 +-
 xen/include/asm-x86/flushtlb.h          |   2 +-
 xen/include/asm-x86/guest_pt.h          |   2 +-
 xen/include/asm-x86/hvm/domain.h        |   2 +-
 xen/include/asm-x86/hvm/hvm.h           |  31 ++-
 xen/include/asm-x86/hvm/irq.h           |   2 +-
 xen/include/asm-x86/hvm/nestedhvm.h     |   6 +-
 xen/include/asm-x86/hvm/svm/asid.h      |   2 +-
 xen/include/asm-x86/hvm/svm/nestedsvm.h |   2 +-
 xen/include/asm-x86/hvm/svm/vmcb.h      |   2 +-
 xen/include/asm-x86/hvm/vcpu.h          |  10 +-
 xen/include/asm-x86/hvm/vioapic.h       |   2 +-
 xen/include/asm-x86/hvm/vlapic.h        |   6 +-
 xen/include/asm-x86/hvm/vmx/vmcs.h      |   4 +-
 xen/include/asm-x86/hvm/vmx/vmx.h       |   2 +-
 xen/include/asm-x86/hvm/vpt.h           |   4 +-
 xen/include/asm-x86/irq.h               |   3 +-
 xen/include/asm-x86/ldt.h               |   2 +-
 xen/include/asm-x86/pv/traps.h          |   2 +-
 xen/include/asm-x86/shadow.h            |   4 +-
 96 files changed, 1485 insertions(+), 1515 deletions(-)

-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.