Re: [Xen-devel] [PATCH v1] libxl: prepare environment for domcreate_stream_done

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 07, 2019 at 12:53:38PM +0100, Olaf Hering wrote:
> Am Thu, 7 Mar 2019 11:02:47 +0000
> schrieb Wei Liu <wei.liu2@xxxxxxxxxx>:
> 
> > Have you seen the field been set before entering this function? Or is
> > the if () just a precaution?
> 
> Sorry, this is not the variant I intended to send.
> The assignment was supposed to be unconditionally.
> 
> Today I browsed the code and it was not clear if that backpointer
> is really required. Does anyone know if srs->dcs can ever be something
> else than the dcs which contains that srs?

That code has been changed quite a bit with migration v2 and COLO. I
wouldn't be surprised if some code becomes stale.

Sadly I won't have time today to dig into the history.

Wei.

> 
> Olaf



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel