Re: [Xen-devel] [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Markus Armbruster [mailto:armbru@xxxxxxxxxx]
> Sent: 13 March 2019 17:45
> To: qemu-devel@xxxxxxxxxx
> Cc: sstabellini@xxxxxxxxxx; Anthony Perard <anthony.perard@xxxxxxxxxx>; Paul 
> Durrant
> <Paul.Durrant@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx; 
> qemu-block@xxxxxxxxxx
> Subject: [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where 
> appropriate
> 
> Patch created mechanically by rerunning:
> 
>     $ spatch --sp-file scripts/coccinelle/qobject.cocci \
>              --macro-file scripts/cocci-macro-file.h \
>              --dir hw/block --in-place
> 
> Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  hw/block/xen-block.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
> index 70fc2455e8..9c722b9b95 100644
> --- a/hw/block/xen-block.c
> +++ b/hw/block/xen-block.c
> @@ -771,7 +771,7 @@ static XenBlockDrive *xen_block_drive_create(const char 
> *id,
>              QDict *cache_qdict = qdict_new();
> 
>              qdict_put_bool(cache_qdict, "direct", true);
> -            qdict_put_obj(file_layer, "cache", QOBJECT(cache_qdict));
> +            qdict_put(file_layer, "cache", cache_qdict);
> 
>              qdict_put_str(file_layer, "aio", "native");
>          }
> @@ -796,7 +796,7 @@ static XenBlockDrive *xen_block_drive_create(const char 
> *id,
>      qdict_put_str(driver_layer, "driver", driver);
>      g_free(driver);
> 
> -    qdict_put_obj(driver_layer, "file", QOBJECT(file_layer));
> +    qdict_put(driver_layer, "file", file_layer);
> 
>      g_assert(!drive->node_name);
>      drive->node_name = xen_block_blockdev_add(drive->id, driver_layer,
> --
> 2.17.2


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel