Re: [Xen-devel] [PATCH 1/2] xen: introduce a cpumask with all bits set

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.03.19 at 10:59, <jgross@xxxxxxxx> wrote:
> --- a/xen/arch/x86/io_apic.c
> +++ b/xen/arch/x86/io_apic.c
> @@ -1881,7 +1881,6 @@ static void __init check_timer(void)
>      int apic1, pin1, apic2, pin2;
>      int vector, ret;
>      unsigned long flags;
> -    cpumask_t mask_all;
>  
>      local_irq_save(flags);
>  
> @@ -1892,8 +1891,7 @@ static void __init check_timer(void)
>      vector = IRQ0_VECTOR;
>      clear_irq_vector(0);
>  
> -    cpumask_setall(&mask_all);
> -    if ((ret = bind_irq_vector(0, vector, &mask_all)))
> +    if ((ret = bind_irq_vector(0, vector, &cpumask_all)))
>          printk(KERN_ERR"..IRQ0 is not set correctly with ioapic!!!, 
> err:%d\n", ret);

I actually question this use: check_timer() gets called before
any APs get onlined, so cpumask_of(0) should be equally fine
here. But the uses in the scheduler perhaps still warrant the
new object, and the code here can as well be cleaned up later.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel