[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored
- To: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Mon, 18 Mar 2019 16:35:03 +0000
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx, Paul Durrant <paul.durrant@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>
- Delivery-date: Mon, 18 Mar 2019 16:35:59 +0000
- Ironport-data: A9a23:Mmxgr6A90ZyuqRVWkefolHO6SiHEJmYLOzaM4r1jcMHBJnwesl4CDx ytrmxHLOu53AyZScAA6YM+zRal1tkqP3iKpYkrgitmLrNtXkyrJPq4nXvqyR8k+06W2Lp1KO 9Bn5dHdc0PM1JFTMJ6lcggZ2PeH4FJVqQvQGmGzAI78pRE5R6AQz480WrV1gzgMtHGQYqTkM Sw9sbk5m/l9Xk39jKTL8CqLK7i7blJFbcGeBwb4cbPWp27JaoEJhPzAZFFn83kMAAINxYytF QsOauqe98eQqwhVCLgEjJESQYgnQXoPCaOrjCEE1Foznmnfv/w7BsSn6rOjTQgl/puvX9d8c u81omwdboAE9+DUX8gNvGKoUx3TmaPpOv3bVco16kwOiHUXXsv8QW5Kt7DgrG1cW5N+CMcgB OaHMF7X3/4yhVk+W0w1j83LibaNVG8fq4D6KJtLgaps9WzF6Rc+wY82+plNpF2Deafe3Reyt 47YSh5mUIdsSac7Ao+n2S7HtlJAFsC5/dBXcfK3199WSKCMUmBZbizFzDVgJu9k9mLDzyUFl /oVNbYmqxz1fVbvXgEBx4BShGcGGH8cak6SbdQxEWmvvNI9/aLmpaXQ3gLFHLaQ7WcRHJEoX C7sniW0eVJhmnrf/19S3uhGXcLLdiAjiGbrdM6MxKKH8eQatQr1WG+jgCd8l9GqjkeyHzz5N 3krn9wT+pSKxFKWpJ/IL5UqEiOfr0w6IPuaV5En94UCvVXrKakWrOUHCWZXHHS4UsvDbhDx3 Blf5O1JElHW3iWMBI9YvdWiKFYER3eiLAa4CBfmXQyyqf6P79J00gzU11bHkVUEDiZ2CsfG+ bN2nNuTucYmgGci74ymPn5vZjXXdd6JyUj2PhtJSiTCE1JxA8ufN5IHkbyehTxjzSsiZ3ja8 ORZle0hdgDuMwaz2qiQ4nysbYocY7SF2IvollPUKT6Qgd55W0E5Yur+eY1PF178dV6nONqIQ vPw+452QGD1qco9kHewKf+Yxw3avvqZYP3HquxeJFJBNNouNbCFF/aNHfMX4GtYaEPqRC9Jd luO6RboYMe1fwnq4PNnh7lKq/0Hv52kdMVzRxMygVLVNoIgIABUEeaFjeWvf1CsLJrUknerY gzFb7WcH1xfD5TtK0ZAegaFaFKtNFDhKQWWR6S6HKrbxs0OsFN6GcnMCPQUjpOZFeBQEFilZ CY92H0QAueSeHc+q/6lB7/veY3NJTCIpnlLXM3C6rff/t2ymmOYNHQmR+pZAI/suSV9NH2G/ pjPhR2ASRQ0rpx0ZJ+b1aEjyJ3ekHk7rCbKZuzKa8D6iJvoQiRHLZYDJGkCJZlTovowH4EKB fAk3yNTn4lpGdCfrhTftECgVHxtVjc9H23Rr2DokAIAERZ03PNF/vdAAAcQsA6JfOfyag6as yacmMQptYRqQvI0hs+X89gmiLB/huwKXq22O0DnlwDMERNnB6o7XVuvFoQXhqEMUd+eXT/LC 1aIobWXqFCXDT6LYyP713mI37KHsfX17dDFxtf/AX01FjnQBF3bs0+KRFanrdMN6zaXxuUMe hKSaVDptknoU8F5+/h6zI8QeT7B+mjU6RLKnsLw22PEGzdD8HCLhB/9SQguCYSJFX5Gk7qbb njvI1LLzEctds/zIykcq/EeXH9wk/GpUtc6/dFj7jdDET2ZZyAp9uuCSMn2VKSXPNVePBnjQ P5CsfqLXaPOCHCFyXX+YCzt1imkmMerppmS8R3Qp5J2kD1/f6Atk4y8pENtVROyzUoVc7EIw bvEu1edr1I/FKn7e7zsxoMRGpwkoel4ZRaMyqArKqQGzuR+1F/1U8rs30DsoR7uA7MadrQ82 G56aLFYDpgYzkBBRKk01400p+xRsvzIm0A0qn5b3SPelnLU4dsKCmc/usGDc6ReduNfdsojk oZJDyTaq8XtV/BbE6WrEGKIHx42ax96NLcO2Z4mUiRPD/Dd6209Nhxx/mNRYmJV4g8jc9XoU 1MACqONOSYbwhxKNL6fzK6gF5eSwnNiCsAfpDZpyW3VnkgOePwnpunrx+lYGrAlqD+jZpM8m J1cFM9xOnd1QFbuLA4BwSo2RVVwUANve95vBBKa9055XN5pH4NwYUX7vOE2Qab+2lZpu5g/+ /xlHvfviut
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Mar 18, 2019 at 03:48:59PM +0000, Igor Druzhinin wrote:
> On 18/03/2019 15:45, Roger Pau Monne wrote:
> > diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c
> > index 349f72d00c..23de5517db 100644
> > --- a/hw/i386/xen/xen-mapcache.c
> > +++ b/hw/i386/xen/xen-mapcache.c
> > @@ -185,8 +185,13 @@ static void xen_remap_bucket(MapCacheEntry *entry,
> > }
> >
> > if (!dummy) {
> > + /*
> > + * If the caller has requested the mapping at a specific address
> > use
> > + * MAP_FIXED to make sure it's honored.
> > + */
>
> Since the comment now applied to both invocation - could it be moved
> outside the if statement then?
That sounds good to me.
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
