[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored
- To: Anthony Perard <anthony.perard@xxxxxxxxxx>, Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
- From: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
- Date: Mon, 18 Mar 2019 16:36:01 +0000
- Accept-language: en-GB, en-US
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>
- Delivery-date: Mon, 18 Mar 2019 16:38:31 +0000
- Ironport-data: A9a23:8AdJTquWXHXQ3rZNTBbkftV38efnOphVZjjmV/efNq3fuXmx3RfKvw neSTiNjGgzNUD54mApGo9mLb8zwZdvCydzyLEjYAdkQO3MfPkYOEeV8ZXtrb8TULekx5ymf5 HYrsg7f1S9VDDo+eIDOPbxgdJ+i1anqkQQ6vRq8eoJUZl63Qkh1Z8KjE0T+2Ml5NMIfwW+IT jufbgB/h0BZZ+PyjlGJkFuYJ8bdRcVfU2+ww8n+wtDbq/rMBRc1SRilkqx2qf2NPIOf6Dmpf sEnjAw8uvwCxIviQ0PFnqChfSxUuAjeKgKMbk05K3v/eIs6k4YCMYRHRCsNKrhtehJAapv2A s+NpD/Li0H1+VQTGoP7PmaOA8EkGudxdrvEH2KeL/eNj8gXm80xLWeCxC2/KcaQ+zi29VRy4 ZhzZ5cJWmP1RA8C4huRWxQ9jMvZw9EsbbQEpMOBqiG8Nx8tKV47uokO+uOuchlChSBYIkjX3 uo79bulDuG7aYnmcy0kkvDaVc2Q2NlRP5tHbBfdpJStWnn8puU/HabMaOi2aIvQ4mgMYCYLC XxKXgrk5vKh+K9gyQP9q8zKrfxM2D6PW0YICd9qgPXOCVTBBzrC2+pf2rpRP7PfDm5BLvKtR fcAQgwWyaeFKqhVGGMJTk2GZI+39cHPzlMIF4lJYTovVdqDjoq2dYG6rRK0R+HKxkzJoc/o6 bf0XObqw51YW1jf9VXt84PHe3h3cnB51m9y87y/sg3n63YbUm5AJC+9c6eRrhmLOevftugeC +ZMvwqiUYPzSH4XA4goUDXUrPbcC9PuNTaeEQE7/eXW3SJWmhw1zmTIW4tBxvjkJOnvASQ4f ubuYs/2lSILCbQmVb01lCLapf2SKFr/TQg5grg8WqlAsVRoUzMgEZVkZtI6asks24Ep7AafO jtJmpVTgSOtriOtuMVUyRpHAFp1q8DWW7IbLv7awoA4MXVNJvCW9Dk62hLIsdC+ob9/P4M/U 3g6zO8pzNKO9qhNW01aHO4BP5RS8ghTXLWVMpxzupouJ2kWWxDuuoQXS0x5hd5ZOZ36owJn8 GJBfgmmI3K2Pws7WpP1q60tw1LcSOT2pQtd+h8nxrqVZ16d/e1FAY61hn09CB/H13qGXILQs 7azsstPEaWMNQA6v8u1XdbDyMpPG67Ap1Mj5F5GlQE9JrS2MgX45BWBBFY+c7lzQsf2UAd25 yPVJBi9pMLwx3mQtO4mJNsSETUqjapuMfUmEUzBCow7Dw49wi5aRTfQw8RLHKpEWotkTb9MO gDawOQ1160tqMzm8gXih5nubUkyeidv8gYxxhatlmEVdJoMI/gpCcw1gTHcO8YbPGBrW3mw8 7x6iGc8a7aZSCmsUPKBaOq+xvKgaMpKSPd2H3kHcgGPr4GFH0SiNjU8BHQ7odAuy3jR5KfbG fabk53r6JD8EC6hRSzzezzClyIYEbBMqCq4epwQbRRE88Bgrz2Nqlk0xfzz3G9N0ZOP5jHy1 ZXfT6n/hKK1dJ8iz0H+miwundYedbCLGNDReKIs95wfc3Pdw0YLlDFYK+O7RuxPAaRIhO+Gt ZGrpmwcB042m3dqQ16I/Ej2NPr2FAWxTCzp7XdZwEO1wG8E4Z2OABHrkBvOqMGvznNi+axha l7IA1pv43QDbxFAUqCFPTOhy34nQL4kMfmT3Lk4Ib/NEETpOpiZEoCD7yw1ZMiWnDhM7X0qW qQRtW8WjCy0hh9oz5EcrVab1ROMpoSalk6LtwOjOQ2Xd03lb5bNZJLT/E4bbFID2yL7cVXVz IW3vFuwhlv28HQ0fDFV48nvqM7/lFiH4rYQXE62JgHaRQj/s5+qeJRupepJRDwmkK33XQJwf 72RB0QjCowC7sreauriV/jYrqXBXUSvUPqL2VPK1laJ3fvzjukNoeaVQg2wUADPKtVsOZcGK ox4f6mjOYoaKWlP2rOq7GYzvBr9e1IcIWXF4eFsekelM8y6jyqfomysdlJrvAUd6GCA8T5m3 LHnbFimAEaV7Eo+eipPdQDCCFEflFN3vFCKHS3s/U8CwQtGxqj9MP1Z4Kueds2ShKtubBBob Y07GEPWQuPkWQ7c1ogLR9eAW9nKFagUud/l79pGJk5wUV6faMIGwaud0420ZGd2DzcxdMQwQ /xtkW/QsSiOahQDPVHhN6TQzCPStpLXDuTYG0aVO42ErhTYdCOi3M=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHU3aGu87VY9TI/c0+y7cr3AfSBy6YReCyAgAAM34CAABDsYA==
- Thread-topic: [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored
> -----Original Message-----
> From: Anthony PERARD [mailto:anthony.perard@xxxxxxxxxx]
> Sent: 18 March 2019 16:35
> To: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>; qemu-devel@xxxxxxxxxx; Stefano
> Stabellini
> <sstabellini@xxxxxxxxxx>; Paul Durrant <Paul.Durrant@xxxxxxxxxx>; Paolo
> Bonzini <pbonzini@xxxxxxxxxx>;
> Richard Henderson <rth@xxxxxxxxxxx>; Eduardo Habkost <ehabkost@xxxxxxxxxx>;
> Michael S. Tsirkin
> <mst@xxxxxxxxxx>; Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>;
> xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2] xen-mapcache: use MAP_FIXED flag so the mmap address
> hint is always honored
>
> On Mon, Mar 18, 2019 at 03:48:59PM +0000, Igor Druzhinin wrote:
> > On 18/03/2019 15:45, Roger Pau Monne wrote:
> > > diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c
> > > index 349f72d00c..23de5517db 100644
> > > --- a/hw/i386/xen/xen-mapcache.c
> > > +++ b/hw/i386/xen/xen-mapcache.c
> > > @@ -185,8 +185,13 @@ static void xen_remap_bucket(MapCacheEntry *entry,
> > > }
> > >
> > > if (!dummy) {
> > > + /*
> > > + * If the caller has requested the mapping at a specific address
> > > use
> > > + * MAP_FIXED to make sure it's honored.
> > > + */
> >
> > Since the comment now applied to both invocation - could it be moved
> > outside the if statement then?
>
> That sounds good to me.
I have no problem and my R-b still stands.
Paul
>
> --
> Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
