Re: [Xen-devel] [PATCH v2 2/2] x86/pvshim: use 2M alignment

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.03.19 at 14:05, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/configs/pvshim_defconfig
> +++ b/xen/arch/x86/configs/pvshim_defconfig
> @@ -5,6 +5,7 @@ CONFIG_PVH_GUEST=y
>  CONFIG_PV_SHIM=y
>  CONFIG_PV_SHIM_EXCLUSIVE=y
>  CONFIG_NR_CPUS=32
> +CONFIG_XEN_ALIGN_2M=y
>  # Disable features not used by the PV shim
>  # CONFIG_SHADOW_PAGING is not set
>  # CONFIG_BIGMEM is not set

Instead of this, why not add

    default XEN_ALIGN_2M if PV_SHIM_EXCLUSIVE

to the config option itself, ahead of the default patch 1 establishes?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel