Re: [Xen-devel] Xen commit 9b0bc91b3 possibly removed too much info from README

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Apr 16, 2019 at 09:28:01PM +0800, Kevin Buckley wrote:
> On Mon, 15 Apr 2019 at 17:24, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> >
> > On Sat, Apr 13, 2019 at 11:17:48AM +0800, Kevin Buckley wrote:
> > > On Thu, 11 Apr 2019 at 18:29, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > > >
> > > > ...
> > > > Sure. I will write a patch.
> > > >
> > > > Wei.
> > >
> > > Couple of other things I noticed after posting the original observation,
> > > that might be of use in patching the documentation
> > >
> > > 1)
> > >
> > > The tools/Makefile has a bare PYTHON EnvVar that isn't seemingly
> > > replaced by the PYTHON= value supplied to configure, so I also
> > > needed to specify the
> > >
> > > PYTHON=/path/to/interpreter
> > >
> > > as an argument to the "make world" as well as to the configure.
> >
> > The only appearance of PYTHON in tools/Makefile is in the qemu build.
> > It already has the right form.
> >
> > I tested the following:
> >
> >     $ PYTHON=/usr/bin/python3 ./configure
> >     $ make -j8 world 2>&1 | tee log # broken atm unfortunately
> >     $ make -C tools subdir-all-qemu-xen-dir # the rune which has PYTHON in 
> > it
> >
> > And then I looked for the relevant bits in log:
> >
> > PKG_CONFIG_PATH=/local/work/xen.git/tools/../tools/pkg-config${PKG_CONFIG_PATH:+:${PKG_CONFIG_PATH}}
> >  \
> > $source/configure --enable-xen --target-list=i386-softmmu \
> >         ....
> >         --python=python3 \
> >
> > Not sure which bare PYTHON EnvVar you referred to. Can you clarify?
> 
> 
> Here's what i did having pulled the master at commit cb70a26
> 
> tar xf /path/to/xen-cb70a26.tar.gz
> 
> cd xen-master/
> 
> PYTHON=/usr/bin/python3 ./configure --prefix=/usr   \
>    --disable-seabios   \
>    --disable-qemu-traditional  \
>    --disable-rombios     \
>    --disable-stubdom 2>&1 | tee ../config.log
> 
> make EFI_DIR=/usr/lib/efi world 2>&1 | tee ../make_world_3.out
> 
> 
> ...
> gcc -Wp,-MD,tools/kconfig/.zconf.tab.o.d    -D_GNU_SOURCE
> -D_DEFAULT_SOURCE -DCURSES_LOC="<ncurses.h>" -DNCURSES_WIDECHAR=1
> -DLOCALE  -Itools/kconfig -c -o tools/kconfig/zconf.tab.o
> tools/kconfig/zconf.tab.c
> gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/zconf.tab.o
> tools/kconfig/conf -s --silentoldconfig Kconfig
> make[3]: Leaving directory '/usr/src/xen/xen-master/xen'
> make -f Rules.mk _install
> make[3]: Entering directory '/usr/src/xen/xen-master/xen'
> make -C tools
> make[4]: Entering directory '/usr/src/xen/xen-master/xen/tools'
> make symbols
> make[5]: Entering directory '/usr/src/xen/xen-master/xen/tools'
> gcc -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer
> -fno-strict-aliasing -Wdeclaration-after-statement -o symbols
> symbols.c
> make[5]: Leaving directory '/usr/src/xen/xen-master/xen/tools'
> make[4]: Leaving directory '/usr/src/xen/xen-master/xen/tools'
> make -f /usr/src/xen/xen-master/xen/Rules.mk include/xen/compile.h
> make[4]: Entering directory '/usr/src/xen/xen-master/xen'
>  Xen 4.13-unstable
> /bin/sh: python: command not found
> make[4]: *** [Makefile:169: include/xen/compile.h] Error 127

Here. The PYTHON invocation is from the hypervisor build, not the tools
build.

Thanks for the log.  I will have a closer look.

> make[4]: Leaving directory '/usr/src/xen/xen-master/xen'
> make[3]: *** [Makefile:137: /usr/src/xen/xen-master/xen/xen] Error 2
> make[3]: Leaving directory '/usr/src/xen/xen-master/xen'
> make[2]: *** [Makefile:45: install] Error 2
> make[2]: Leaving directory '/usr/src/xen/xen-master/xen'
> make[1]: *** [Makefile:123: install-xen] Error 2
> make[1]: Leaving directory '/usr/src/xen/xen-master'
> make: *** [Makefile:165: world] Error 2
> 
> 
> Note the
> 
> /bin/sh: python: command not found
> 
> whilst, in the tools/Makefile,, I see

I think tools build is fine. It's hypervisor build that is broken.


Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel