Re: [Xen-devel] Xen project CI systems and committer workflow

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.04.19 at 16:02, <ian.jackson@xxxxxxxxxx> wrote:
> Andrew Cooper writes ("Re: Xen project CI systems and committer workflow"):
>> While everything presented here is fine to do as a matter of policy, the
>> committers still need to retain the ability to actually push directly to
>> the staging branches on xen.git
> 
> Why ?
> 
> In particular, this seems to presuppose that these "staging" branches
> continue to exist.
> 
> One of our strange practices is that we push things to a non-rewinding
> branch before they have been tested.  Now, OK, we have been doing that
> for over a decade - since before people really invented the modern
> concept of "CI" - but that doesn't make it sensible.

Now the question of course is - why do you consider this practice
"strange"? And what do you mean by "before they have been
tested"? Any submitter should have tested their patches. Yes, not
everyone tests all possible (basic) configurations, but we spot
such issues in review more often than they slip through, I think.
And I don't expect CI will come anywhere near testing all
_possible_ configurations, i.e. the risk of subtle breakage won't
get eliminated altogether anyway.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel