[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 2/2] x86/iommu: avoid mapping the APIC configuration space for hwdom
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Tue, 23 Jul 2019 16:09:38 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AccA2uSwIlwi8bTmbs8rr+AaKqsmRO45PG3QNYoxyEw=; b=Z9lUcRnlCsOGMcr0VbqxvFFPJJQmwagGqKih+rXAQUGhTR4WHux/i4ZBNab07MyCIZupS4HKdOwIl5YQXtxMV09OCwKLMpDYqnk1jNEPefTzv01V7IDUoacqcWPjUqAaubVX/c2wP6TWREhteL38Xlgqvg6bb6gFR5YdOE3V3rvJ9J3gfPATymMuwrBnNzWrdMk1XNE1jMZrFl9mTz9iFKlcuuarUQhnjFPLe6f7bO0AFeZjMbR/CUsD4PSQlxzbPshPy08jLqBIQZ51xIMNkOuzJpWIki4Y1ggKB5J5gK1sTzbYA77GmGLmt2z7rRsPTXau//mevAbd7PRtSgZFpw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AGFX7MQZW+yWHyCnEblBcCIDrUEy94zwYewe1jp4A+MPTM63XZiHARgFuwMB1+h60TrsQ9Apoq74Ko2KuS3JYhcP1Ywh2ThHJz2kSIYF8wxWyp7T4jsE5/M9ytDUYH+arNzLuDaUmI5rMsAJDQPdgMWGUEvV2tomPdPEt7Ejy2cPm4E7Uj+Vv3GVWRjeYu9wGaN610vT23x9H8xvltojE+cI/ZDF/H9O6yy/5YRwPCLklOdUbtDIOVRSK66YYSzT8Kv47bE3wCgzgF0Wq3ilTeSVeVL0IUsID20APMXqPBwBdDNV4alp+mYeORbZyixC4LhEYPjYU5eSTZr5Iq7xmw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Tue, 23 Jul 2019 16:15:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQW4zrYUYVM3HpUS5nJG7cGq72KbYXymA
- Thread-topic: [PATCH 2/2] x86/iommu: avoid mapping the APIC configuration space for hwdom
On 23.07.2019 17:48, Roger Pau Monne wrote:
> Current code only prevents mapping the io-apic page into the guest
> physical memory map. Expand the range to be 0xFECx_xxxx as described
> in the Intel 3 Series Chipset Datasheet section 3.3.1 "APIC
> Configuration Space (FEC0_0000h–FECF_FFFFh)".
>
> AMD also lists this address range in the AMD SR5690 Databook, section
> 2.4.2 "Non-SB IOAPIC Support".
But that's chipset specific. I don't think we can blindly assume
this range. Just in case one small remark on the change itself as
well:
> @@ -229,10 +229,9 @@ static bool __hwdom_init hwdom_iommu_map(const struct
> domain *d,
> /* Check that it doesn't overlap with the Interrupt Address Range. */
> if ( pfn >= 0xfee00 && pfn <= 0xfeeff )
> return false;
> - /* ... or the IO-APIC */
> - for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ )
> - if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )
> - return false;
> + /* ... or the APIC Configuration Space. */
> + if ( pfn >= 0xfec00 && pfn <= 0xfecff )
> + return false;
Despite the chipset documentation calling it just APIC, in our
code I think it would be better if a connection to IO-APIC was
made, to avoid ambiguity.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
