Re: [Xen-devel] [PATCH] create-diff-object: more precisely identify .rodata sections

["Wieczorkiewicz, Pawel" <wipawel@xxxxxxxxx>]

> On 18. Sep 2019, at 13:19, Julien Grall <julien.grall@xxxxxxx> wrote:
> 
> Hi Pawel,
> 
> On 18/09/2019 11:44, Wieczorkiewicz, Pawel wrote:
>>> On 18. Sep 2019, at 12:41, Ian Jackson <ian.jackson@xxxxxxxxxx> wrote:
>>> 
>>> Julien Grall writes ("Re: [PATCH] create-diff-object: more precisely 
>>> identify .rodata sections"):
>>>> On 18/09/2019 10:52, Wieczorkiewicz, Pawel wrote:
>>>>> $ scripts/./add_maintainers.pl -d ~/git/livepatch-build-tools
>>>> 
>>>> '-d' only tells you where the patches files are. The script will look up 
>>>> for the
>>>> MAINTAINERS file in the current directory.
>>> 
>>> Hmmm.  I wonder if we could detect this situation somehow.  This will
>>> be a common user error I think.
>>> 
>> I should have looked twice before sending the patch out. But, what would be 
>> very helpful for me
>> is additional option to the add_maintainers.pl script like: -m ./MAINTAINERS
> 
> Well the filename will always be the same, so at best you will provide 
> redundant information.

Not if I create a git-ignored symlink to the other repo.

> 
> However, it is not uncommon to have script that needs to apply on the current 
> directory. What would a new option add? Is it just avoid to do a "cd ..." 
> before?
> 

Mainly the new option will avoid the 'cd', but it will also force me to specify 
the right file.

The option can be totally optional with a CWD as a default fallback.

> Cheers,
> 
> -- 
> Julien Grall

Best Regards,
Pawel Wieczorkiewicz






Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel