[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] create-diff-object: more precisely identify .rodata sections
- To: "Wieczorkiewicz, Pawel" <wipawel@xxxxxxxxx>
- From: Julien Grall <julien.grall@xxxxxxx>
- Date: Wed, 18 Sep 2019 12:35:49 +0100
- Cc: Lars Kurth <lars.kurth@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, KonradRzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "Tim \(Xen.org\)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "Pohlack, Martin" <mpohlack@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxx>
- Delivery-date: Wed, 18 Sep 2019 11:36:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18/09/2019 12:27, Wieczorkiewicz, Pawel wrote:
On 18. Sep 2019, at 13:19, Julien Grall <julien.grall@xxxxxxx> wrote:
Hi Pawel,
On 18/09/2019 11:44, Wieczorkiewicz, Pawel wrote:
On 18. Sep 2019, at 12:41, Ian Jackson <ian.jackson@xxxxxxxxxx> wrote:
Julien Grall writes ("Re: [PATCH] create-diff-object: more precisely identify
.rodata sections"):
On 18/09/2019 10:52, Wieczorkiewicz, Pawel wrote:
$ scripts/./add_maintainers.pl -d ~/git/livepatch-build-tools
'-d' only tells you where the patches files are. The script will look up for the
MAINTAINERS file in the current directory.
Hmmm. I wonder if we could detect this situation somehow. This will
be a common user error I think.
I should have looked twice before sending the patch out. But, what would be
very helpful for me
is additional option to the add_maintainers.pl script like: -m ./MAINTAINERS
Well the filename will always be the same, so at best you will provide
redundant information.
Not if I create a git-ignored symlink to the other repo.
Why would you do that...?
add_maintainers.pl and get_maintainers.pl relies to be used on ./MAINTAINERS. I
am quite reluctant to allow any other use as you increase the risk for the user
to misuse the scripts.
However, it is not uncommon to have script that needs to apply on the current directory.
What would a new option add? Is it just avoid to do a "cd ..." before?
Mainly the new option will avoid the 'cd', but it will also force me to specify
the right file.
The option can be totally optional with a CWD as a default fallback.
Which completely defeats the purpose of forcing you the specify the right
file...
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
