[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/7] x86/mce: bring hypercall subop compat checking in sync again


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 14 Jul 2020 16:31:57 +0200
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 14 Jul 2020 14:32:08 +0000
  • Ironport-sdr: l8GoQ23qy4S7V7XESdJ18zy/KiZNdFpDs5A2qjD1RZE1PXg9JqtiWwHqLD9TJuDKEI4zFYjUvh OugjLDZO+RsyLsVBu61su+PkptPNFpSCnC2YSK0d8GI6e6IvKaQtEAwvtfSaDGICi+xgmz8lyN /w3LIMIRe5rKuf+vDmf/0X7U1wQJXVUgylRFLbtLUBtxgfoOKXmWP2h0QWBImH3BopUWdFiFLX incJZEybQeDu3um0C58UrAGDmlw95mwy4DUyrVOWPheerc+8xvqOzbe8XM2PMuTbd1K9U0NDwp TXY=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jul 14, 2020 at 01:47:11PM +0200, Jan Beulich wrote:
> On 14.07.2020 13:19, Roger Pau Monné wrote:
> > On Wed, Jul 01, 2020 at 12:26:54PM +0200, Jan Beulich wrote:
> >> Use a typedef in struct xen_mc also for the two subops "manually"
> >> translated in the handler, just for consistency. No functional
> >> change.
> > 
> > I'm slightly puzzled by the fact that mc_fetch is marked as needs
> > checking while mc_physcpuinfo is marked as needs translation,
> > shouldn't both be marked as needing translation? (since both need to
> > handle a guest pointer using XEN_GUEST_HANDLE)
> 
> I guess I'm confused - I see an exclamation mark on both respective

No, I was the one confused, you are right that both are marked as need
translation.

Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.