[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/8] Arm: prune #include-s needed by domain.h

On 15/07/2020 11:39, Jan Beulich wrote:
asm/domain.h is a dependency of xen/sched.h, and hence should not itself
include xen/sched.h. Nor should any of the other #include-s used by it.
While at it, also drop two other #include-s that aren't needed by this
particular header.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -2,7 +2,7 @@
  #define __ASM_DOMAIN_H__
#include <xen/cache.h>
-#include <xen/sched.h>
+#include <xen/timer.h>
  #include <asm/page.h>
  #include <asm/p2m.h>
  #include <asm/vfp.h>
@@ -11,8 +11,6 @@
  #include <asm/vgic.h>
  #include <asm/vpl011.h>
  #include <public/hvm/params.h>
-#include <xen/serial.h>

While we don't need the rbtree.h, we technically need serial.h for using vuart_info.

I would rather prefer if headers are not implicitly included whenever it is possible.


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.