[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/vhpet: Fix type size in timer_int_route_valid

  • To: Eslam Elnikety <elnikety@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 28 Jul 2020 10:58:15 +0200
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <pdurrant@xxxxxxxxxxxx>
  • Delivery-date: Tue, 28 Jul 2020 08:58:42 +0000
  • Ironport-sdr: /bZkDnZuXjo0SWY7PwnfnFfGpru2vPR112n/AkE305ku0uelirJMTzl1CNgdCMVtSFeIrfCMas 1tFUaiYgODKpcIbW7ltXyvR/Ie4ojvYaRMvJwT1r2pJ2TtTags9CgqoKPUVqd8Y9Y09tNKDRg9 LMZHN6Ge9XQCD8ckxOmixPSKMBSZg3hBNJ4vfWIRUORJRDhU18AcJAtoLSak+lKW9skwRbCea+ QcHDVfT4eKoODdhezggYh6X+mYxb4dNIHNbT0gR1jrsne4mJ0ce+U9XnpDfcXprbf+Xv4RakOq dwA=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jul 28, 2020 at 08:33:57AM +0000, Eslam Elnikety wrote:
> The macro timer_int_route_cap evalutes to a 64 bit value. Extend the
> size of left side of timer_int_route_valid to match.

I'm very dull with this things, so forgive me.

Isn't the left side just promoted to an unsigned 64bit value?

Also timer_int_route will strictly be <= 31, which makes the shift

I'm not opposed to switching to use unsigned long, but I think I'm not
understanding the issue.

Thanks, Roger.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.