[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/vhpet: Fix type size in timer_int_route_valid

Hi Roger,

On 28.07.20 10:58, Roger Pau Monné wrote:
On Tue, Jul 28, 2020 at 08:33:57AM +0000, Eslam Elnikety wrote:
The macro timer_int_route_cap evalutes to a 64 bit value. Extend the
size of left side of timer_int_route_valid to match.

I'm very dull with this things, so forgive me.

Isn't the left side just promoted to an unsigned 64bit value?

Also timer_int_route will strictly be <= 31, which makes the shift

This is all true. The size mismatch is indeed benign. The patch is only for code sanity.

I'm not opposed to switching to use unsigned long, but I think I'm not
understanding the issue.

Thanks, Roger.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.