[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 28 Jul 2020 11:06:54 +0200
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 28 Jul 2020 09:07:18 +0000
  • Ironport-sdr: uTmgI8PxOzjXzTKFv/wuH25kCpkMuPEwq+7BWgPZv2kPlz8v6EpZPXhdFEz2dNXOmtaPEzonHB DCqEQ+nr//gDEkJQQkWdv5HeExG4xCv+cPStmbGxdX6oY7kLO/wx94zJtSzt1e18eM0iTb/+CJ CCVBwOV1uUQL77JM6ap2ZVHm4vhtZX8xhWPV8WtaKVYcRVeykIdBOWJLRbMRs3meBxi4EygrUB wetHtNoxdoHKPRp0MLQDcOMEp5Gr2o2wXG3wvww6WsdwtU5AnVQP3uzqFsoVXyjW2CLC34QUYs jQ4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Jul 27, 2020 at 09:47:52PM +0200, Jan Beulich wrote:
> On 27.07.2020 16:55, Roger Pau Monné wrote:
> > On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote:
> > > --- /dev/null
> > > +++ b/xen/include/asm-x86/asm-defns.h
> > 
> > Maybe this could be asm-insn.h or a different name? I find it
> > confusing to have asm-defns.h and an asm_defs.h.
> While indeed I anticipated a reply to this effect, I don't consider
> asm-insn.h or asm-macros.h suitable: We don't want to limit this
> header to a more narrow purpose than "all sorts of definition", I
> don't think. Hence I chose that name despite its similarity to the
> C header's one.

I think it's confusing, but I also think the whole magic we do with
asm includes is already confusing (me), so if you and Andrew agree
this is the best name I'm certainly fine with it. FWIW:

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Please quote the clac/stac instructions in order to match the other
usages of ALTERNATIVE.

Thanks, Roger.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.