[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y



On 25.08.2020 12:37, George Dunlap wrote:
> As an explanation, there are a combination of things. You proposed A (remove 
> the dependency), Ian proposed B (use move-if-changed), but we’re hoping to do 
> C (have an external tree) before the next release.  I haven’t had the time to 
> look into either B or C (nor, unfortunately, to review Nick’s submissions to 
> other parts of the code — sorry Nick!); but I’ve still been reluctant to go 
> for A.
> 
> I think basically, unless someone is ready to tackle B or C immediately, we 
> should just check in Jan’s fix (or probably better, just revert the patch 
> that introduced the dependency).  It will be annoying to have to potentially 
> fix up the generated golang bindings, but that puts the incentives in the 
> right place.

One additional aspect to consider is that I ran into the issue actually
in a 4.14 tree (because it just so happened that the timestamps of the
involved files were "right" for the problem to be hit), i.e. whatever
we decide to do will also end up needing backporting. To me this looks
to make A less attractive.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.