[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/8] tools/libxl: Simplify DOMCTL_CDF_ flags handling in libxl__domain_make()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 1 Oct 2020 11:26:58 +0200
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Thu, 01 Oct 2020 09:27:25 +0000
- Ironport-sdr: YLR2UGa1tE/4RMGxGxWxNWWSOwGUipKOqwsyH3eBqcYZjFEq6f63Dql0AuQVpWWc8J5UVkWSdj 08njLDOgm0tgc62yUVqmg3zOEZ3E2+FUFUyYtucP/bO6tM6nzLIz9YeiZf/V1XOuBt9Mc59Bke tPLBAOyw1Fpdi608BbI8st/nsxAPQffcqHvudLfS+PDU4ujYohsT6s9Z/5OeP0S/xhAILZSqT6 /zdmADLoNm4tgPXNHSRAEKgdUIcaiNBqetH+bvISmUDaf6KZcCbH9KN5vIwD1GiiWrwpIu5PNW PWY=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Sep 30, 2020 at 02:42:41PM +0100, Andrew Cooper wrote:
> The use of the ternary operator serves only to obfuscate the code. Rewrite it
> in more simple terms, avoiding the need to conditionally OR zero into the
> flags.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Might be worth adding to the log that it's a non-functional change.
Thanks, Roger.
|
